Deduped recieved scopes #6581
Merged
Deduped recieved scopes #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #22487 ↗︎
Details:
Review all test suite changes for PR #6581 ↗︎ |
|||||||||||||||
jc-harrison
reviewed
May 9, 2024
| @@ -210,7 +210,9 @@ async def query_to_scopes(query_dict): | |||
| except Exception: | |||
| raise BadQueryError | |||
| agg_unit = await get_agg_unit(query_dict) | |||
| return [f"{agg_unit}:{tl_query_name}:{query_name}" for query_name in query_list] | |||
| return list( | |||
There was a problem hiding this comment.
Do we need this to be a list, or could we return a set instead? (I don't think it matters much either way, but if we return a set it's perhaps clearer that the scopes will be non-duplicated)
There was a problem hiding this comment.
It's compared to other lists when we check it against the requested scopes; now I say that, a set would be better there too, but that probably belongs in a different PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6581 +/- ##
===========================================
- Coverage 92.31% 77.11% -15.20%
===========================================
Files 268 268
Lines 10586 10586
Branches 855 855
===========================================
- Hits 9772 8163 -1609
- Misses 676 2169 +1493
- Partials 138 254 +116 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6580
I have:
Description
Passes the output of
flowapi.permissions.query_to_scopesthrough aset()before returning