Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'SELECT DISTINCT ON' in LastLocation #6622

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Use 'SELECT DISTINCT ON' in LastLocation #6622

merged 3 commits into from
Jun 12, 2024

Conversation

jc-harrison
Copy link
Member

Closes #6603

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Rewrites the SQL for LastLocation to use SELECT DISTINCT ON instead of a window function.

@jc-harrison jc-harrison added FlowMachine Issues related to FlowMachine refactoring performance labels May 22, 2024
@greenape
Copy link
Member

Acceptance tests for generated sql need updating

@cypress Cypress
Copy link

cypress bot commented Jun 11, 2024 •
edited

Passing run #22810 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into faster-last-location
Project: FlowAuth Commit: 746c9faf28
Status: Passed Duration: 00:43 💡
Started: Jun 12, 2024 9:04 AM Ended: Jun 12, 2024 9:05 AM

Review all test suite changes for PR #6622 ↗︎

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (582139d) to head (3acdac7).

❗ Current head 3acdac7 differs from pull request most recent head 746c9fa

Please upload reports for the commit 746c9fa to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6622   +/-   ##
=======================================
  Coverage   92.30%   92.31%           
=======================================
  Files         268      268           
  Lines       10586    10586           
  Branches      855      855           
=======================================
+ Hits         9771     9772    +1     
  Misses        676      676           
+ Partials      139      138    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Jun 12, 2024
@mergify mergify bot merged commit e30ce06 into master Jun 12, 2024
39 checks passed
@mergify mergify bot deleted the faster-last-location branch June 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenape greenape greenape approved these changes

Assignees
No one assigned
Labels
FlowMachine Issues related to FlowMachine performance ready-to-merge Label indicating a PR is OK to automerge refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update LastLocation to use SELECT DISTINCT ON
2 participants
@jc-harrison @greenape