Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python deps and Airflow #6393

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Bump python deps and Airflow #6393

merged 11 commits into from
Nov 9, 2023

Conversation

jc-harrison
Copy link
Member

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Bumps python deps and Airflow image

@jc-harrison jc-harrison added the dependencies Pull requests that update a dependency file label Nov 7, 2023
@jc-harrison
Copy link
Member Author

For some reason, "markers": "python_version >= '3.6'" has appeared in the flowclient and flowkit-jwt-generator deps in Pipfile.lock, and pipenv doesn't like this. Maybe I've unwittingly upgraded pipenv on my machine, and it's now incompatible with the CircleCI version?

FlowETL pip install is also failing in the build step. Unclear whether that's related or a different issue - FlowETL doesn't use pipenv, and doesn't require flowclient or flowkit-jwt-generator.

Copy link

cypress bot commented Nov 7, 2023

Passing run #21423 ↗︎

0 4 0 0 Flakiness 0

Details:

Bump deps again
Project: FlowAuth Commit: ca0b545838
Status: Passed Duration: 00:49 💡
Started: Nov 9, 2023 4:07 PM Ended: Nov 9, 2023 4:08 PM

Review all test suite changes for PR #6393 ↗︎

@jc-harrison
Copy link
Member Author

For some reason, "markers": "python_version >= '3.6'" has appeared in the flowclient and flowkit-jwt-generator deps in Pipfile.lock, and pipenv doesn't like this. Maybe I've unwittingly upgraded pipenv on my machine, and it's now incompatible with the CircleCI version?

FlowETL pip install is also failing in the build step. Unclear whether that's related or a different issue - FlowETL doesn't use pipenv, and doesn't require flowclient or flowkit-jwt-generator.

Indeed, my local pipenv has updated, and we were using a very old CI image. Using a more recent image has fixed the pipenv issue, but there's now an issue with installing ruby dependencies for the AutoFlow tests.

And the FlowETL pip install issue persists.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #6393 (ca0b545) into master (189c0d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6393   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         263      263           
  Lines       10302    10302           
  Branches      835      835           
=======================================
  Hits         9578     9578           
  Misses        596      596           
  Partials      128      128           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jc-harrison jc-harrison merged commit 101f76b into master Nov 9, 2023
40 checks passed
@jc-harrison jc-harrison deleted the bump-deps-20231106 branch November 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant