Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps and pin base images #6406

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Bump deps and pin base images #6406

merged 2 commits into from
Nov 20, 2023

Conversation

jc-harrison
Copy link
Member

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Re-locks all python dependencies.

Also pins base docker images for flowapi, flowmachine and flowauth, using sha256 digests. Going forward, ideally all base image tags should constrain to an image version that we expect to work, and the digests can be routinely bumped along with dependency files.

@jc-harrison jc-harrison added FlowAuth Issues related to FlowAuth FlowMachine Issues related to FlowMachine FlowAPI Issues related to the FlowKit API dependencies Pull requests that update a dependency file docker labels Nov 20, 2023
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

cypress bot commented Nov 20, 2023

Passing run #21466 ↗︎

0 4 0 0 Flakiness 0

Details:

Re-lock python deps
Project: FlowAuth Commit: cdf3d5ceaf
Status: Passed Duration: 00:41 💡
Started: Nov 20, 2023 11:43 AM Ended: Nov 20, 2023 11:43 AM

Review all test suite changes for PR #6406 ↗︎

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2f3ead) 92.96% compared to head (cdf3d5c) 92.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6406   +/-   ##
=======================================
  Coverage   92.96%   92.97%           
=======================================
  Files         263      263           
  Lines       10302    10302           
  Branches      835      835           
=======================================
+ Hits         9577     9578    +1     
  Misses        596      596           
+ Partials      129      128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jc-harrison jc-harrison added the ready-to-merge Label indicating a PR is OK to automerge label Nov 20, 2023
@mergify mergify bot merged commit c7365b3 into master Nov 20, 2023
42 checks passed
@mergify mergify bot deleted the bump-deps-20231120 branch November 20, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker FlowAPI Issues related to the FlowKit API FlowAuth Issues related to FlowAuth FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants