Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase index fillfactor on cache tables #6598

Merged
merged 2 commits into from
May 21, 2024
Merged

Increase index fillfactor on cache tables #6598

merged 2 commits into from
May 21, 2024

Conversation

greenape
Copy link
Member

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Makes the default fill factor of cache table indexes 100, which will marginally reduce their disk usage

@greenape greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine labels May 15, 2024
@greenape greenape requested a review from jc-harrison May 15, 2024 10:37
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (d4e3a6e) to head (05b76c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6598   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         268      268           
  Lines       10586    10586           
  Branches      855      855           
=======================================
  Hits         9772     9772           
  Misses        676      676           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

cypress bot commented May 20, 2024

Passing run #22599 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into index-fillfactor
Project: FlowAuth Commit: 05b76c5897
Status: Passed Duration: 00:57 💡
Started: May 20, 2024 12:53 PM Ended: May 20, 2024 12:54 PM

Review all test suite changes for PR #6598 ↗︎

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label May 21, 2024
@mergify mergify bot merged commit 0b12bdc into master May 21, 2024
41 checks passed
@mergify mergify bot deleted the index-fillfactor branch May 21, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants