Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration 20200513223401 creates wrong result #367

Closed
kdambekalns opened this issue Jan 28, 2021 · 2 comments · Fixed by #387
Closed

Migration 20200513223401 creates wrong result #367

kdambekalns opened this issue Jan 28, 2021 · 2 comments · Fixed by #387
Labels
T: Bug

Comments

@kdambekalns
Copy link
Member

kdambekalns commented Jan 28, 2021 •
edited
Loading

After running this migration, I see _hiddenInIndex being replaced by neosneos_hidden_in_index:

Screenshot 2021-01-28 at 20 15 41

It should result in neos_hidden_in_index, though.

Update: And __parentPath becomes neos_parent_path (with a trailing space!)
@kitsunet
Copy link
Member

kitsunet commented Dec 1, 2021 •
edited
Loading

This whole migration is way to aggressive. it just turned a customer instance into totally broken, because also a .children([_hidden = true]) was changed as well as a something_something_hidden in their own package sql migrations and ORM index annotations. I would actually say we should remove this migration as the useful case is definitely rarer IMHO than the "wrong" case.

@daniellienert
Copy link
Contributor

Hey guys, sorry for that. Thats really bad. Lets remove it. I'd supply a patch.

@daniellienert daniellienert mentioned this issue Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: Bug
Projects
None yet
Milestone
No milestone
3 participants
@kdambekalns @kitsunet @daniellienert