Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add user management module #23

Merged
merged 3 commits into from Dec 7, 2019

Conversation

kdambekalns
Copy link
Member

This adds a user management module to the Neos backend and allows
to delete expired users using a CLI command.

@kdambekalns
Copy link
Member Author

This is a draft for now, as it includes the cleanup up for review as #22 - if that is merged, this one will be easier to review.

@kdambekalns kdambekalns marked this pull request as ready for review November 6, 2019 15:07
@kdambekalns kdambekalns changed the base branch from 3.0 to master November 6, 2019 15:08
@kdambekalns kdambekalns changed the base branch from master to 3.0 November 6, 2019 15:08
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this and it even works on my machine.
Also the code makes sense to me even though i did not review it in extreme detail.

Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it after some struggle it worked fine.
Maybe rebasing would be nice because of the PSR-7 change from @kitsunet this PR is not working out of the box.

Also had a little glitch with the new react ui.
The language label was not rendered (just in the non react part) But maybe it is an caching issue becuase the new ui uses the language data from the xliff.json.

Bildschirmfoto 2019-12-06 um 11 15 38
Bildschirmfoto 2019-12-06 um 11 15 21

@mficzel
Copy link
Member

mficzel commented Dec 6, 2019

@markusguenther this pr is for the 3.x branch wich does not work for 5.x. I tested on 5.1 by locally merging the pr into the package master (which runs on 5.0). If merged this will probably be released as version 3.1 for Neos 4.x and as 4.1 for Neos 5.x

To be able to use the labels in the new UI we need the configuration bit different.
Otherwise the labels don't show up in the xliff.json
@markusguenther
Copy link
Member

markusguenther commented Dec 6, 2019

@markusguenther this pr is for the 3.x branch wich does not work for 5.x. I tested on 5.1 by locally merging the pr into the package master (which runs on 5.0). If merged this will probably be released as version 3.1 for Neos 4.x and as 4.1 for Neos 5.x

Ah ok then this was my fault.
I already fixed the translation thing with the new UI. As the "old" part is using fluid renderings they don't need the content of the xliff.json.

@kdambekalns kdambekalns merged commit 5e0c0d3 into Flowpack:3.0 Dec 7, 2019
@kdambekalns kdambekalns deleted the feature/be-module branch December 10, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants