FEATURE: Neos 9.0 compatibility #51
Conversation
this one ^^ --filter testNodeCreationMatchesSnapshot1
…ing `node_templates` cr
See neos/neos-development-collection#4322 if this actually correct behavior or not
…ed explicitly Backport of #51 The idea is we move more and more to separating the "command" creation and the actual apply should go through flawless. This will enable us validating the template without applying it.
|
Some notes: related: #50 related: #35 (comment) references need special handling: https://github.com/neos/neos-ui/blob/4681fd003d9f9b6a14a47440d859265bad35044e/Classes/Domain/Model/Changes/Property.php#L152-L180 Question is, how to support usecases like #60 as flowquery will only work with a "real" node and we have one yet. Maybe we need a helper for this? edit: as discussed in #70 (comment) we will make the |
I think for this use case, the flowquery is not the problem: the nodes we try to get should be already materialized. The problem is: ATM we can copy the nodes when reacting to the signal; in the future, the target is not yet materialized and we have to modify the template based on the nodes we want to copy. Although this would be part of the package implementing the feature, we should think about how this could be done. |
mhsdesign
changed the base branch from
2.0
to
bugfix/66-correct-constraint-checks
…thQueuedMutators' into neos9
…QueuedMutators' into neos9
mhsdesign
force-pushed
the
neos9
branch
3 times, most recently
from
6bd8b45
to
ea3512b
Compare
- introduce TemplateNodeCreationHandlerFactory - adjust to api changes in cr (NodeType::hasProperty) - fix unit tests - fix functional tests - add unstructured node and cr root
As the logic is not anymore in Neos, and we execute the tests synchronous
mhsdesign
changed the title
|
The node creation handler overhaul was merged neos/neos-ui#3519 and the node was made workspace aware neos/neos-development-collection#5042, the biggest changes in Neos 9 that would affect this package are done and the main functionality of this package is now fully compatible (without patches) with the latest beta Neos9-Beta10. |
…rsistence Previously the doctrine entities would still exist of the previous test.
Neos.ContentRepository.Core/Classes/EventStore/EventPersister.php:47 RuntimeException: A transaction is active already, can't commit events! ----------- and succeeding errors: Neos.ContentRepository.Core/Classes/Infrastructure/DbalCheckpointStorage.php:88 RuntimeException: Failed to acquire checkpoint lock for subscriber "Neos\ContentRepository\Core\Projection\ContentStream\ContentStreamProjection" because a transaction is active already
…f `$$nodeType` does not exist like in v2
This change introduces support for Neos 9.
When starting the development it was eminent that not all features of NodeTemplates version 1.0 could be considered. To ease maintenance the version 2 of NodeTemplates was a complete rewrite for this package in anticipation of Neos 9. It removed incompatible features but also introduced new functionalities. The core functionality was rewritten to not depend on active records so it can be adjusted to issue a set of content repository commands.
That way it became possible to reuse the test-suite as well as parts of the core domain and be up-mergeable.
Multiple up-merges from version 2 have been successful and this strategy will allow us to fix bugs or ease introducing new minor features.
That being said all features of NodeTemplates version 2 are herby adjusted/refactored to work with Neos 9 while passing all tests:
Core functionality, NodeTemplates via
options.templateFull support of the feature set of version 2.
The deprecated EEL context variable
triggeringNodewas removed as discussed. Please usesiteorparentNodeinstead.flow nodetemplate:validateIncludes new
--siteoption: the Neos site, which determines the content repository. Defaults to the first available one.flow nodeTemplate:createFromNodeSubtreeIncludes new
--siteoption: the Neos site, which determines the content repository. Defaults to the first available one.Additional notes
NodeCreationService::generateUriPathSegment(see also discussion to move it into the core)Flowpack\NodeTemplates\Domain\NodeCreation\NodeMutatorwas replaced by using native ESCR commandsTransientNodebut not in other parts that should be up-mergeable (likeTemplate)NodeCreationHandlerInterfaceneos/neos-ui#3519defaultValueviaCreateNodeAggregateWithNode::$initialPropertyValuesneos/neos-development-collection#5154 / see also DISCUSSION: Shouldproperty: nullbe ignored? #41