Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Implement countReserved, countFailed and countReady #3

Merged
merged 1 commit into from May 30, 2018
Merged

FEATURE: Implement countReserved, countFailed and countReady #3

merged 1 commit into from May 30, 2018

Conversation

daniellienert
Copy link
Contributor

Comply with next major doctrine-common QueueInterface

bwaidelich
bwaidelich approved these changes May 29, 2018
View reviewed changes
Copy link
Collaborator

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!
I'd love to have some tests for this, but I just realized that we haven't had any so far o.O
Can be done for the main features in a separate PR

@daniellienert
FEATURE: Implement countReserved, countFailed and countReady
b4338dd 
Comply with next major doctrine-common QueueInterface
@daniellienert daniellienert merged commit ee87d59 into Flowpack:master May 30, 2018
@daniellienert daniellienert deleted the task/implement-interface branch May 30, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniellienert @bwaidelich