Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Add translations for labels, finish German translation #226

Merged
merged 3 commits into from Jan 9, 2024
Merged

TASK: Add translations for labels, finish German translation #226

merged 3 commits into from Jan 9, 2024

Conversation

lorenzulrich
Copy link
Contributor

What I did

  • I brought the German labels in Sync with the English ones
  • I added additional labels where they already existed in the TypeScript files, but were not in the XLF
  • I added some additional translate(), translateById() calls where labels were hardcoded

@lorenzulrich lorenzulrich force-pushed the task/translations branch 2 times, most recently from e84907f to 66e2e25 Compare December 28, 2023 17:15
Sebobo
Sebobo requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx so much!
Left some comments, but also have to check some labels and words again whether they match the usual Neos language style and feel "right" in the UI.

Resources/Private/JavaScript/asset-upload/src/components/PreviewSection.tsx Outdated Show resolved Hide resolved
Resources/Private/JavaScript/asset-upload/src/components/PreviewSection.tsx Outdated Show resolved Hide resolved
Resources/Private/JavaScript/asset-collections/src/components/DeleteButton.tsx Outdated Show resolved Hide resolved
Classes/GraphQL/Resolver/Type/MutationResolver.php Show resolved Hide resolved
Resources/Private/Translations/en/Main.xlf Outdated Show resolved Hide resolved
@lorenzulrich
Copy link
Contributor Author

Left some comments, but also have to check some labels and words again whether they match the usual Neos language style and feel "right" in the UI.

FYI, for the German translation, I used the wordings used in the old Media UI where available, e.g. Asset, but Sammlungen, Tags etc.

@lorenzulrich lorenzulrich force-pushed the task/translations branch 2 times, most recently from 6f3c304 to b7ab82c Compare December 28, 2023 20:11
Sebobo
Sebobo requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed, then it's fine IMO

Classes/GraphQL/Resolver/Type/MutationResolver.php Show resolved Hide resolved
@Sebobo Sebobo merged commit 6283e3d into Flowpack:main Jan 9, 2024
5 checks passed
@Sebobo
Copy link
Member

Sebobo commented Jan 9, 2024

Thx @lorenzulrich

@Sebobo Sebobo mentioned this pull request Jan 9, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebobo Sebobo Sebobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorenzulrich @Sebobo