Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --destination option #24

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

martin-minarik
Copy link
Contributor

@martin-minarik martin-minarik commented Aug 30, 2023

Resolves issue #23

  1. Added "--destination" option to parser.
  2. Added a "destination" parameter to the "download(...)"
    and "download_video_audio(...)" functions located in the "download.py".
  3. Passed destination to "pytube.YouTube.download(...)" located in "download_video_audio(...)".

=)

@martin-minarik martin-minarik changed the title feat: --destination option feat: --destination option, #23 Aug 30, 2023
@martin-minarik martin-minarik changed the title feat: --destination option, #23 feat: --destination option, resolve #23 Aug 30, 2023
@martin-minarik martin-minarik changed the title feat: --destination option, resolve #23 feat: --destination option, resolves #23 Aug 30, 2023
@martin-minarik martin-minarik changed the title feat: --destination option, resolves #23 feat: --destination option Aug 30, 2023
Copy link
Owner

@Flowrey Flowrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, seems good to me, maybe you can just add a short flag -d and remove the named parameters in commands.download.

youtube_bz/main.py Outdated Show resolved Hide resolved
youtube_bz/main.py Outdated Show resolved Hide resolved
@Flowrey
Copy link
Owner

Flowrey commented Aug 31, 2023

Thanks for the change, just one last thing the CI doesn't pass, you just need to run black and isort --profile=black on your code, and i will merge.

@Flowrey
Copy link
Owner

Flowrey commented Aug 31, 2023

You forgot to run isort --profile=black . 😜

@martin-minarik
Copy link
Contributor Author

I see that it quite depends on which working directory it's being called from.

I tried calling it from youtube_bz/commands and it seemed to work fine the first time. (°々°)

@Flowrey Flowrey merged commit 732ee3e into Flowrey:master Sep 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants