-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --destination option #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, seems good to me, maybe you can just add a short flag -d
and remove the named parameters in commands.download
.
Thanks for the change, just one last thing the CI doesn't pass, you just need to run |
You forgot to run |
I see that it quite depends on which working directory it's being called from. I tried calling it from youtube_bz/commands and it seemed to work fine the first time. (°々°) |
Resolves issue #23
and "download_video_audio(...)" functions located in the "download.py".
=)