Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the progress bar during download progression #26

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

yr1404
Copy link
Contributor

@yr1404 yr1404 commented Sep 13, 2023

Added the specified changes suggested in #9

@Flowrey
Copy link
Owner

Flowrey commented Sep 14, 2023

Hey, thanks for the PR !
I think we can now remove the [Downloading] and [Downloaded] print statement from the download function,
otherwise it will collapse with the progress bar.
We also need to add tqdm to poetry requirements, see here.
Make sure to also run black . and isort . --profile=black at the root of the project, for the CI to pass 😃

@Flowrey
Copy link
Owner

Flowrey commented Sep 15, 2023

Thanks!

@Flowrey Flowrey merged commit 51dc089 into Flowrey:master Sep 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants