Bump org.assertj:assertj-core from 3.24.2 to 3.25.3 (#2117)

* Bump org.assertj:assertj-core from 3.24.2 to 3.25.3 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.3. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.24.2...assertj-build-3.25.3) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * remove assertj from spock module as it caused tests to fail --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alphonse Bendt <alphonse.bendt@gmail.com>
FluentLenium · May 4, 2024 · 93692e8 · 93692e8
1 parent a43419a
commit 93692e8
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 23 deletions.
diff --git a/examples/cucumber/pom.xml b/examples/cucumber/pom.xml
@@ -38,7 +38,7 @@
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>
-            <version>3.24.2</version>
+            <version>3.25.3</version>
             <scope>test</scope>
         </dependency>
     </dependencies>

diff --git a/fluentlenium-spock/pom.xml b/fluentlenium-spock/pom.xml
@@ -36,11 +36,6 @@
             <type>pom</type>
             <scope>compile</scope>
         </dependency>
-        <dependency>
-            <groupId>org.assertj</groupId>
-            <artifactId>assertj-core</artifactId>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>org.objenesis</groupId>
             <artifactId>objenesis</artifactId>

diff --git a/...rc/test/groovy/io/fluentlenium/adapter/spock/description/TestDescriptionAccessSpec.groovy b/...rc/test/groovy/io/fluentlenium/adapter/spock/description/TestDescriptionAccessSpec.groovy
@@ -3,8 +3,6 @@ package io.fluentlenium.adapter.spock.description
 import io.fluentlenium.adapter.spock.FluentSpecification
 import io.github.bonigarcia.wdm.managers.ChromeDriverManager
 
-import static org.assertj.core.api.Assertions.assertThat
-
 class TestDescriptionAccessSpec extends FluentSpecification {
 
     def TEST_METHOD = "shouldRetrieveNames"
@@ -15,19 +13,19 @@ class TestDescriptionAccessSpec extends FluentSpecification {
     }
 
     def setup() {
-        assertThat(getTestClass()).isEqualTo(TEST_CLASS)
-        assertThat(getTestMethodName()).isEqualTo(TEST_METHOD)
+        getTestClass() == TEST_CLASS
+        getTestMethodName() == TEST_METHOD
     }
 
     def shouldRetrieveNames() {
         expect:
-        assertThat(getTestClass()).isEqualTo(TEST_CLASS)
-        assertThat(getTestMethodName()).isEqualTo(TEST_METHOD)
+        getTestClass() == TEST_CLASS
+        getTestMethodName() == TEST_METHOD
     }
 
     def cleanup() {
-        assertThat(getTestClass()).isEqualTo(TEST_CLASS)
-        assertThat(getTestMethodName()).isEqualTo(TEST_METHOD)
+        getTestClass() == TEST_CLASS
+        getTestMethodName() == TEST_METHOD
     }
 
 }
diff --git a/.../src/test/groovy/io/fluentlenium/adapter/spock/smoketest/SmokeTestNewWebDriverSpec.groovy b/.../src/test/groovy/io/fluentlenium/adapter/spock/smoketest/SmokeTestNewWebDriverSpec.groovy
@@ -6,8 +6,6 @@ import org.openqa.selenium.WebDriver
 import org.openqa.selenium.chrome.ChromeDriver
 import org.openqa.selenium.chrome.ChromeOptions
 
-import static org.assertj.core.api.Assertions.assertThat
-
 class SmokeTestNewWebDriverSpec extends FluentSpecification {
 
     def setupSpec() {
@@ -23,7 +21,7 @@ class SmokeTestNewWebDriverSpec extends FluentSpecification {
 
     def "smokeTest"() {
         expect:
-        assertThat(getDriver()).isInstanceOf(ChromeDriver.class)
+        getDriver() instanceof ChromeDriver
     }
 
 }
diff --git a/...lenium-spock/src/test/groovy/io/fluentlenium/adapter/spock/smoketest/SmokeTestSpec.groovy b/...lenium-spock/src/test/groovy/io/fluentlenium/adapter/spock/smoketest/SmokeTestSpec.groovy
@@ -5,8 +5,6 @@ import io.github.bonigarcia.wdm.managers.ChromeDriverManager
 import org.openqa.selenium.chrome.ChromeDriver
 import org.openqa.selenium.support.events.EventFiringWebDriver
 
-import static org.assertj.core.api.Assertions.assertThat
-
 class SmokeTestSpec extends FluentSpecification {
 
     def setupSpec() {
@@ -15,9 +13,9 @@ class SmokeTestSpec extends FluentSpecification {
 
     def "smokeTest"() {
         expect:
-        assertThat(getDriver()).isInstanceOf(EventFiringWebDriver.class)
-        EventFiringWebDriver driver = (EventFiringWebDriver) getDriver()
-        assertThat(driver.getWrappedDriver()).isInstanceOf(ChromeDriver.class)
+        getDriver() instanceof EventFiringWebDriver
+        EventFiringWebDriver driver = getDriver() as EventFiringWebDriver
+        driver.getWrappedDriver() instanceof ChromeDriver
     }
 
 }

diff --git a/pom.xml b/pom.xml
@@ -234,7 +234,7 @@
             <dependency>
                 <groupId>org.assertj</groupId>
                 <artifactId>assertj-core</artifactId>
-                <version>3.24.2</version>
+                <version>3.25.3</version>
             </dependency>
             <dependency>
                 <groupId>org.atteo.classindex</groupId>