Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor static Impl class #515

Closed
filipcynarski opened this issue Jul 7, 2017 · 2 comments
Closed

Refactor static Impl class #515

filipcynarski opened this issue Jul 7, 2017 · 2 comments
Labels
refactoring

Comments

@filipcynarski
Copy link
Member

Refactor static Impl class - it is to much for me :) Should be refactored.
@filipcynarski filipcynarski added this to the 3.4 milestone Jul 7, 2017
@filipcynarski filipcynarski modified the milestones: 3.5, 3.4 Aug 30, 2017
@filipcynarski filipcynarski removed this from the 3.5 milestone Oct 19, 2017
@slawekradzyminski
Copy link
Member

I made few fixes here and now this class is called SharedWebdriverSingletonImpl. @filipcynarski you can take a look and decide if it's still worth doing:

package org.fluentlenium.adapter.sharedwebdriver;

slawekradzyminski added a commit that referenced this issue May 29, 2019
@slawekradzyminski
#515 - further refactoring changes in SharedWebDriver
a5d12f1
@coveralls coveralls mentioned this issue May 29, 2019
Merged
slawekradzyminski added a commit that referenced this issue May 31, 2019
@slawekradzyminski
#515 - Various CI feedback actions (Code style, Java 8 compatibility)…
f2cde26 
… + added unit tests for DriverLifecycle.THREAD
slawekradzyminski added a commit that referenced this issue May 31, 2019
@slawekradzyminski
#515 - fixed wildcard import
9ef2980
slawekradzyminski added a commit that referenced this issue May 31, 2019
@slawekradzyminski
Merge pull request #848 from FluentLenium/feature/#515
71b7e9a 
#515 - further refactoring changes in SharedWebDriver
@slawekradzyminski
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filipcynarski @slawekradzyminski