Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change handling Before and After from Cucumber #612

Closed
koryl opened this issue Aug 14, 2018 · 1 comment
Closed

Change handling Before and After from Cucumber #612

koryl opened this issue Aug 14, 2018 · 1 comment
Assignees
@koryl
Labels
cucumber feature
Milestone
3.7

Comments

@koryl
Copy link
Collaborator

koryl commented Aug 14, 2018

I was noticed, that when using FL with Cucumber, the user is forced to add in every single class hooks Before(super::before) and After(super::after) due to fact, that Cucumber makes adding these hooks to BaseTest and inheriting them impossible. When these hooks are stored in single class, NullPointerException is occurred.
To prevent this, I propose to check possibility to use composition over inheritance architecture.
@koryl koryl added the feature label Aug 14, 2018
@koryl koryl added this to the 3.7 milestone Aug 14, 2018
@koryl koryl self-assigned this Aug 14, 2018
@koryl koryl added the cucumber label Aug 14, 2018
@koryl
Copy link
Collaborator Author

koryl commented Aug 21, 2018

Pull request #618 waiting for merge.
This new feature makes FluentLenium to handle of creation Cucumber steps and thanks to that it is possible to use FL without inheritance from FluentCucumberTest.

@koryl koryl closed this as completed Aug 21, 2018
@koryl koryl mentioned this issue Aug 22, 2018
Closed
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge branch 'develop' into feature/#612
d590d69
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge branch 'develop' into feature/#612
1cff737
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge branch 'develop' into feature/#612
6a05264
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge branch 'develop' into feature/#612
77bcdc7
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge pull request #618 from FluentLenium/feature/#612
c9b6327 
Feature/#612 Added FluentCucumber
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge branch 'develop' into feature/#612
ca70b62
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge pull request #622 from FluentLenium/feature/#612
c82f0d3 
Feature/#612 Improvements for FluentCucumber integration
slawekradzyminski pushed a commit that referenced this issue Dec 15, 2018
@koryl
Merge pull request #624 from FluentLenium/feature/#612
3a371e6 
Feature/#612 Fixed found issue with injecting elements with FluentCucumber
@koryl koryl mentioned this issue Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koryl koryl

Labels
cucumber feature
Projects
None yet
Milestone
3.7
Development

No branches or pull requests
1 participant
@koryl