New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests platform independent #202
Conversation
public class UrlUtil { | ||
|
||
private UrlUtil() { | ||
throw new UnsupportedOperationException("No instances allowed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this class final should be OK without this exception.
Please indent with 4 spaces instead of tabs |
I think we should get rid of the constants defined in |
But tests are running fine on my computer (ubuntu) |
I use Eclipse with spaces only formatter. It's awkward why Git thinks, there's a difference between yours and mine. Is it some Linux vs. Windows thing? |
Don't know if getting rid of the constants defined in LocalFluentCase is useful. What happens if the HTML file name changes? You would have to adapt all tests using the file instead of changing it in one place. However, this should be done in another pull request if necessary. |
I think, Travis crashed. 😅
|
…mer/FluentLenium into feature/reorganize-tests
Thanks @logineimer. Is the work over with this branch ? I'll try to give a try tomorrow. |
I've rebased everything in a single commit because commit history was weird, with branching and merging ... But it's merged, thanks. |
I managed to get the tests running with the default Maven structure (
src/test/resources
). Unfortunately, I had to copyUrlUtil
class into each project because Maven doesn't provide test code in thefluentlenium-core
dependency.Could you please verify the changes?