Add optional filter to AddFluentValidationAutoValidation() #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
JeremySkinner
requested changes
Mar 28, 2023
There was a problem hiding this comment.
Thanks for this @pgauledev. The build is currently failing as it introduces 2 API breaking changes (introducing the new constructor parameters without providing backwards compatibility overloads), but apart from that it looks good. If you can make these changes then I can get this merged in.
(If you run a build locally with release configuration you can see this errors, or just with a dotnet build)
src/FluentValidation.AspNetCore/FluentValidationModelValidatorProvider.cs
Show resolved
Hide resolved
src/FluentValidation.AspNetCore/FluentValidationModelValidatorProvider.cs
Show resolved
Hide resolved
pgauledev
force-pushed
the
AddOptionalFilterToAddFluentValidationAutoValidationMethod
branch
from
ac12af8
to
7fae6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional filter to AddFluentValidationAutoValidation() that will allow client to opt in/out of using FluentValidation. This will help to migrate away from automatic validation.
Original discussion here -FluentValidation/FluentValidation#2091