Support Internal Types In AssemblyScanner #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit solves FluentValidation#1741 by changing AssemblyScanner behavior to look for all types in an assembly instead of exported typed.
|
|
|
Hi @iabdelkareem please see my comment #1741 (comment) This will need to be an opt-in behaviour. I'd suggest adding an additional optional parameter to the DI extension methods If you're able to make these changes I'll then get this reviewed and merged. Thanks. |
- Added support to optionally include internal types in AssemblyScanner and DependencyInjectionExtensions via includeInternalTypes optional parameter - Added Test Coverage. - Added documentation to address the change. FluentValidation#1741
|
Thank you for the quick response and explanation. I agree with you it's much better when including internal types is opt-in. I've updated the PR with the changes including test coverage and documentation. |
|
Thanks, I’m going to be busy for the next couple of days but I’ll try and review it over the weekend. |
|
Merged, thanks! |
|
Thank you ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit solves #1741 by changing AssemblyScanner behavior to look for all types in an assembly instead of exported typed.