add support for registering internal validator types through FluentValidationMvcConfiguration

docs/aspnet.md

@@ -47,7 +47,7 @@ services.AddMvc()
 
 Validators that are registered automatically using `RegisterValidationsFromAssemblyContaining` are registered as `Scoped` with the container rather than as `Singleton`. This is done to avoid lifecycle scoping issues where a developer may inadvertantly cause a singleton-scoped validator from depending on a Transient or Request-scoped service (for example, a DB context). If you are aware of these kind of issues and understand how to avoid them, then you may choose to register the validators as singletons instead, which will give a performance boost by passing in a second argument: `fv.RegisterValidatorsFromAssemblyContaining<PersonValidator>(lifetime: ServiceLifetime.Singleton)` (note that this optional parameter is only available in FluentValidation 9.0 or later).
 
-By default, only public validators will be registered. To include internal validators you can set the `includeInternalTypes` optional parameter to `true` (e.g., `fv.RegisterValidatorsFromAssemblyContaining<PersonValidator>(includeInternalTypes: true)`).
+By default, only public validators will be registered. To include internal validators you can set the `includeInternalValidatorTypes` optional parameter to `true` (e.g., `fv.RegisterValidatorsFromAssemblyContaining<PersonValidator>(includeInternalValidatorTypes: true)`).
 
 You can also optionally prevent certain types from being automatically registered when using this approach by passing a filter to `RegisterValidationsFromAssemblyContaining`. For example, if there is a specific validator type that you don't want to be registered, you can use a filter callback to exclude it:
 

src/FluentValidation.AspNetCore/FluentValidationMvcConfiguration.cs

@@ -87,6 +87,7 @@ public class FluentValidationMvcConfiguration {
 		internal List<Assembly> AssembliesToRegister { get; } = new List<Assembly>();
 		internal Func<AssemblyScanner.AssemblyScanResult, bool> TypeFilter { get; set; }
 		internal ServiceLifetime ServiceLifetime { get; set; } = ServiceLifetime.Scoped;
+		internal bool IncludeInternalValidatorTypes { get; set; }
 
 		/// <summary>
 		/// Whether automatic server-side validation should be enabled (default true).
@@ -98,8 +99,9 @@ public class FluentValidationMvcConfiguration {
 		/// </summary>
 		/// <param name="filter">Optional filter that allows certain types to be skipped from registration.</param>
 		/// <param name="lifetime">The service lifetime that should be used for the validator registration. Defaults to Scoped</param>
-		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblyContaining<T>(Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped) {
-			return RegisterValidatorsFromAssemblyContaining(typeof(T), filter, lifetime);
+		/// <param name="includeInternalTypes">Include internal validators. The default is false.</param>
+		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblyContaining<T>(Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped, bool includeInternalTypes = false) {
+			return RegisterValidatorsFromAssemblyContaining(typeof(T), filter, lifetime, includeInternalTypes);
 		}
 
 		/// <summary>
@@ -108,8 +110,9 @@ public class FluentValidationMvcConfiguration {
 		/// <param name="type">The type that indicates which assembly that should be scanned</param>
 		/// <param name="filter">Optional filter that allows certain types to be skipped from registration.</param>
 		/// <param name="lifetime">The service lifetime that should be used for the validator registration. Defaults to Scoped</param>
-		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblyContaining(Type type, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped) {
-			return RegisterValidatorsFromAssembly(type.Assembly, filter, lifetime);
+		/// <param name="includeInternalTypes">Include internal validators. The default is false.</param>
+		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblyContaining(Type type, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped, bool includeInternalTypes = false) {
+			return RegisterValidatorsFromAssembly(type.Assembly, filter, lifetime, includeInternalTypes);
 		}
 
 		/// <summary>
@@ -118,11 +121,13 @@ public class FluentValidationMvcConfiguration {
 		/// <param name="assembly">The assembly to scan</param>
 		/// <param name="filter">Optional filter that allows certain types to be skipped from registration.</param>
 		/// <param name="lifetime">The service lifetime that should be used for the validator registration. Defaults to Scoped</param>
-		public FluentValidationMvcConfiguration RegisterValidatorsFromAssembly(Assembly assembly, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped) {
+		/// <param name="includeInternalTypes">Include internal validators. The default is false.</param>
+		public FluentValidationMvcConfiguration RegisterValidatorsFromAssembly(Assembly assembly, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped, bool includeInternalTypes = false) {
 			ValidatorFactoryType = typeof(ServiceProviderValidatorFactory);
 			AssembliesToRegister.Add(assembly);
 			TypeFilter = filter;
 			ServiceLifetime = lifetime;
+			IncludeInternalValidatorTypes = includeInternalTypes;
 			return this;
 		}
 
@@ -132,11 +137,13 @@ public class FluentValidationMvcConfiguration {
 		/// <param name="assemblies">The assemblies to scan</param>
 		/// <param name="filter">Optional filter that allows certain types to be skipped from registration.</param>
 		/// <param name="lifetime">The service lifetime that should be used for the validator registration. Defaults to Scoped</param>
-		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblies(IEnumerable<Assembly> assemblies, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped) {
+		/// <param name="includeInternalTypes">Include internal validators. The default is false.</param>
+		public FluentValidationMvcConfiguration RegisterValidatorsFromAssemblies(IEnumerable<Assembly> assemblies, Func<AssemblyScanner.AssemblyScanResult, bool> filter = null, ServiceLifetime lifetime = ServiceLifetime.Scoped, bool includeInternalTypes = false) {
 			ValidatorFactoryType = typeof(ServiceProviderValidatorFactory);
 			AssembliesToRegister.AddRange(assemblies);
 			TypeFilter = filter;
 			ServiceLifetime = lifetime;
+			IncludeInternalValidatorTypes = includeInternalTypes;
 			return this;
 		}
 

src/FluentValidation.AspNetCore/FluentValidationMvcExtensions.cs

@@ -66,7 +66,7 @@ public static class FluentValidationMvcExtensions {
 			var config = new FluentValidationMvcConfiguration(ValidatorOptions.Global);
 			configurationExpression?.Invoke(config);
 
-			services.AddValidatorsFromAssemblies(config.AssembliesToRegister, config.ServiceLifetime, config.TypeFilter);
+			services.AddValidatorsFromAssemblies(config.AssembliesToRegister, config.ServiceLifetime, config.TypeFilter, config.IncludeInternalValidatorTypes);
 			services.AddSingleton(config.ValidatorOptions);
 
 			if (config.ValidatorFactory != null) {