Fix scale precision error message when digits is calculated as negative #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @SatsunkevichAlex thanks for this. I think that rather assigning scale to precision, it'd be clearer if the modification was done at the point where the message argument is appended, so it would become: .AppendArgument("Digits", actualIntegerDigits < 0 ? 0 : actualIntegerDigits)I think this is a bit clearer than assigning the scale variable to the precision variable. If you could make that change then I'll get this merged in for the next release. Thanks! |
|
Applied your recommendation |
|
Thanks, I'll aim to get this in over the weekend. |
JeremySkinner
changed the title
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a possible way to fix wrong scale precision error message
#1791