Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes some issues with paper planes #2031

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1011
Original PR: tgstation/tgstation#81453

About The Pull Request

  1. paper's examine was defined twice, which made spacemandmm throw a minor notice about
  2. paper's altclick had a second arg for some item, which would never be the case because that's not a real arg
  3. there was a check for src's type, now just removed to the type's altclick
  4. some papercode was sitting in paper plane code file, now moved

the rest is misc changes such as replacing camelCase and using SECONDS.

Why It's Good For The Game

None of this is player-facing but it's updating some rather old code to more modern code standards.

Changelog

Nothing player-facing.

* Fixes some issues with paper planes

* Modularize this (better better paper planes)

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Mal <13398309+vinylspiders@users.noreply.github.com>
@Iajret Iajret merged commit 67747c1 into master Feb 19, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1011 branch February 20, 2024 09:25
Iajret pushed a commit that referenced this pull request Apr 17, 2024
* Adds a single brain damage line (#82710)

This pr brought to you by The™ Players™ Club™.

* Adds a single brain damage line

---------

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants