Distinguish tapping on Done and Cancel button in SwiftUIPhotosCropView #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement distinct callback functions onDone() and onCancel() for SwiftUIPhotosCropView which will be called from cropViewController on didFinish and didCancel
|
@andre0805 hi! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
SwiftUIPhotosCropView, there’s no way of telling whether the user tapped Cancel button or Done button in the Crop view because the same callback function is passed tocropViewController.handlers.didFinishandcropViewController.handlers.didCancel. There's a simple and straightforward solution for that, I implemented 2 distinct functions:onDone, which is called when user taps the Done button (passed tocropViewController.handlers.didFinish), andonCancel, which is called when user taps the Cancel button (passed tocropViewController.handlers.didCancel).