Feature/tests #22
Merged
Feature/tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ths ContravariantProjection method for Vector data is now public, so that other modules can leverage this method for handling "Reproject" actions to map from physical to computational coordinates. Because this is normally used for element interior flux calculations, and boundary fluxes are calculated using a Riemann solver, this method now excludes computation of % boundary attributes. * The associated HIP kernels now copy the physical vector components to scalar values so that the input and output arrays can be identical
* This provides the advantage of code re-use and the ability to use the GPU accelerated kernel for the reproject step in the update workflow
* I've also added a step to apply the contravariant projection to the velocity field, prior to calling flux divergence.
* This transition requires moving the velocity attribute to the SELF_Model level. This reduces the amount of development required to implement a new solver with either split-form or conservative methods.
* When GPU acceleration is enabled, we need to copy the interior and boundary solution to the GPU.
* Because SELF dependencies take 1h+ to install, I've separated the cloud build yaml's and Dockerfiles into a "base" and the standard SELF build. The base build creates a container called `self-base` that is used as the starting container for standard SELF builds; the base container is expected to updated at a slower pace than SELF. * The standard SELF build pipelines are broken into a `local.yaml` and the standard `.yaml`. The `cloudbuild.local.yaml` file is expected to be used with cloud-build-local for users to run tests on their local systems, provided they have Docker and cloud-build-local installed.
|
/gcbrun |
|
/gcbrun |
Codecov Report
@@ Coverage Diff @@
## develop #22 +/- ##
=========================================
Coverage ? 7.80%
=========================================
Files ? 16
Lines ? 6805
Branches ? 2966
=========================================
Hits ? 531
Misses ? 5984
Partials ? 290 Continue to review full report at Codecov.
|
* This minimizes management of .gcda and .gcno files generated from coverage reporting
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
* there are a handful of tools that we need to run the gcov and codecov from the base container (curl, gcov, and gcovr) in addition to compiler libraries necessary to execute code.
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in changes to the CI infrastructure to
examples/are now run as part of the tests.