Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Upgrade wizard for problematic content element "sorting" values #1929

Merged

Conversation

cweiske
Copy link
Contributor

@cweiske cweiske commented Mar 8, 2022

Copying pages will fail to adjust the colPos values when the "sorting" value
of child elements is larger than that of its parent record.
This leads to "lost" content records that are visible in the list view,
but not in the web view in the TYPO3 backend.

This problem happens at least when migrating from TYPO3 v7 to v8 while
upgrading to flux 9.5.0.
Old content records exhibit this problem, while newly created content
is fine - TYPO3 takes care of modifying the "sorting" values correctly.

This wizard fixes the problematic sorting values by finding the largest
child sorting value and adjusting the parent's "sorting" accordingly,
as well as all following content element siblings.

Resolves: #1824

…lues

Copying pages will fail to adjust the colPos values when the "sorting" value
of child elements is larger than that of its parent record.
This leads to "lost" content records that are visible in the list view,
but not in the web view in the TYPO3 backend.

This problem happens at least when migrating from TYPO3 v7 to v8 while
upgrading to flux 9.5.0.
Old content records exhibit this problem, while newly created content
is fine - TYPO3 takes care of modifying the "sorting" values correctly.

This wizard fixes the problematic sorting values by finding the largest
child sorting value and adjusting the parent's "sorting" accordingly,
as well as all following content element siblings.

Resolves: FluidTYPO3#1824
@NamelessCoder NamelessCoder self-requested a review March 27, 2022 10:33
@NamelessCoder NamelessCoder merged commit 0c269b0 into FluidTYPO3:development Mar 27, 2022
@NamelessCoder
Copy link
Member

Excellent - thanks @cweiske!

cweiske added a commit to mogic-le/flux that referenced this pull request Mar 30, 2022
We drop support for TYPO3v8 for that feature.

Resolves: FluidTYPO3#1934
Related: FluidTYPO3#1929
cweiske added a commit to mogic-le/flux that referenced this pull request Mar 30, 2022
The v8 API is not available on TYPO3v10 and v11, so to support them
we have to use the new upgrade wizard API.

We drop support for TYPO3v8 for that feature.

See
https://docs.typo3.org/c/typo3/cms-core/9.5/en-us/Changelog/9.4/Feature-86076-NewAPIForUpgradeWizards.html

Resolves: FluidTYPO3#1934
Related: FluidTYPO3#1929
cweiske added a commit to mogic-le/flux that referenced this pull request May 6, 2022
The v8 API is not available on TYPO3v10 and v11, so to support them
we have to use the new upgrade wizard API.

We drop support for TYPO3v8 for that feature.

See
https://docs.typo3.org/c/typo3/cms-core/9.5/en-us/Changelog/9.4/Feature-86076-NewAPIForUpgradeWizards.html

Resolves: FluidTYPO3#1934
Related: FluidTYPO3#1929
@cweiske cweiske deleted the fix-sorting-migration branch May 6, 2022 06:17
NamelessCoder pushed a commit that referenced this pull request May 6, 2022
The v8 API is not available on TYPO3v10 and v11, so to support them
we have to use the new upgrade wizard API.

We drop support for TYPO3v8 for that feature.

See
https://docs.typo3.org/c/typo3/cms-core/9.5/en-us/Changelog/9.4/Feature-86076-NewAPIForUpgradeWizards.html

Resolves: #1934
Related: #1929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child Content Element's Colpos is not Updated on Copy
2 participants