Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuViewHelper does not hide untranslated pages #1498

Open
mbrodala opened this issue Jul 11, 2018 · 1 comment
Open

MenuViewHelper does not hide untranslated pages #1498

mbrodala opened this issue Jul 11, 2018 · 1 comment

Comments

@mbrodala
Copy link
Contributor

We have set up our site with the following to ensure no default content is displayed on translated pages:

config {
  sys_language_overlay = 0
  sys_language_mode = strict
}

However, the MenuViewHelper does not respect this and in fact always falls back to including pages from the default language in the menu.

This is caused by PageService::getMenu() which filters the menu pages by PageService::hidePageForLanguageUid() but does not offer an option to disable the $normalWhenNoLanguage flag.

@mbrodala
Copy link
Contributor Author

A long time ago the behavior we need was default but this was changed with #392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant