Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetInclusion Middleware does not return assets on a cached page #1768

Closed
mkarulin opened this issue May 5, 2022 · 4 comments
Closed

AssetInclusion Middleware does not return assets on a cached page #1768

mkarulin opened this issue May 5, 2022 · 4 comments

Comments

@mkarulin
Copy link

mkarulin commented May 5, 2022

After updating to 6.1.1 and enabling caching, the javascripts that were included using the viewhelper <v:asset.script> stopped working. (Example: <v:asset.script name="handlebars" overwrite="true" movable="true" path="{settings.javascript.handlebars}" />)

The script tag appears only when cache is cleared, and disappears after reloading the page from cache.

I tracked it down to the change implemented in 863e030

TYPO3 versions tested: 9.5, 10.4, 11.5
Problem started with in 6.1.0

Originally posted by @mkarulin in #1736 (comment)

@Keinbockwurst
Copy link

I can confirm this. After Downgrading to 6.0.5 its working again.

@xperseguers
Copy link
Contributor

Confirming this as well.

@cweiske
Copy link
Contributor

cweiske commented May 30, 2022

I had the same problem with v:asset.style on vhs 6.1.1.
The <!-- VhsAssetsDependenciesLoaded ... --> comment would only be there if the page was non-cached.
The patch fixes this problem.

@mkarulin
Copy link
Author

mkarulin commented Jun 7, 2022

When will this be released?
Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants