New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Switch to new unit testing strategy #752
Conversation
->loadConfigurationAndInitialize(FALSE) | ||
->loadTypo3LoadedExtAndExtLocalconf(FALSE) | ||
->initializeLanguageObject() | ||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space found before semicolon; expected ");" but found ")
;"
Note: failed because of bad timezone setting on build server. The warnings that are dispatched should be okay to ignore; when merged to |
Other note: a few |
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
6e0ce39
to
4f726fc
Compare
->loadConfigurationAndInitialize(FALSE) | ||
->loadTypo3LoadedExtAndExtLocalconf(FALSE) | ||
->initializeLanguageObject() | ||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space found before semicolon; expected ");" but found ")
;"
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
@@ -55,6 +57,7 @@ public function getRenderTestValues() { | |||
array(array('content' => '', 'alternative' => 'alternative'), 'alternative'), | |||
array(array('content' => NULL, 'alternative' => 'alternative'), 'alternative'), | |||
array(array('content' => 0, 'alternative' => 'alternative'), 'alternative'), | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out something instead of removing it.
[TASK] Switch to new unit testing strategy
You do not need to review the entire thing. Just make sure that our metadata files are okay and that this patch works on your machine ;)