Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Switch to new unit testing strategy #752

Merged
merged 19 commits into from Jan 17, 2015
Merged

Conversation

NamelessCoder
Copy link
Member

You do not need to review the entire thing. Just make sure that our metadata files are okay and that this patch works on your machine ;)

->loadConfigurationAndInitialize(FALSE)
->loadTypo3LoadedExtAndExtLocalconf(FALSE)
->initializeLanguageObject()
;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space found before semicolon; expected ");" but found ")
;"

@NamelessCoder
Copy link
Member Author

Note: failed because of bad timezone setting on build server. The warnings that are dispatched should be okay to ignore; when merged to development Jenkins will build this with the correct timezone setting and should report green with remarks about missing assertions.

@NamelessCoder
Copy link
Member Author

Other note: a few Tx_* class names of core classes have been replaced with proper namespace versions. It should cause no problems, given that we already require TYPO3 6.2.

@NamelessCoder
Copy link
Member Author

This is an automated comment based on an automated formal commit review.

Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it!

->loadConfigurationAndInitialize(FALSE)
->loadTypo3LoadedExtAndExtLocalconf(FALSE)
->initializeLanguageObject()
;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space found before semicolon; expected ");" but found ")
;"

@NamelessCoder
Copy link
Member Author

This is an automated comment based on an automated formal commit review.

Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it!

@@ -55,6 +57,7 @@ public function getRenderTestValues() {
array(array('content' => '', 'alternative' => 'alternative'), 'alternative'),
array(array('content' => NULL, 'alternative' => 'alternative'), 'alternative'),
array(array('content' => 0, 'alternative' => 'alternative'), 'alternative'),
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out something instead of removing it.

xf- added a commit that referenced this pull request Jan 17, 2015
[TASK] Switch to new unit testing strategy
@xf- xf- merged commit ae1c8fd into development Jan 17, 2015
@NamelessCoder NamelessCoder deleted the workbench/unittestdecouple branch January 20, 2015 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants