-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rr #1219
Merged
Merged
add rr #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复急袭猛禽-崛起叛逆猎鹰可以复制墓地非超量怪兽的问题 以及对方场上怪兽攻击力合计为0仍然能对应发动废品栗子球的问题 升阶没问题,但是我觉得这么改代码会短一点
修复急袭猛禽-崛起叛逆猎鹰和效果伤害相关的一系列问题
修复急袭猛禽-崛起叛逆猎鹰以墓地的同名卡为对象发动复制效果后,仍然可以发动复制效果的bug
修复在墓地时为1速的bug
Wind2009-Louse
suggested changes
Dec 10, 2023
scripts/PHNI-JP/c101203046.lua
Outdated
Comment on lines
48
to
51
function s.settg(e,tp,eg,ep,ev,re,r,rp,chk) | ||
if chk==0 then return Duel.GetLocationCount(tp,LOCATION_SZONE)>0 | ||
and Duel.IsExistingMatchingCard(s.setfilter,tp,LOCATION_DECK,0,1,nil) end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
function s.settg(e,tp,eg,ep,ev,re,r,rp,chk) | |
if chk==0 then return Duel.GetLocationCount(tp,LOCATION_SZONE)>0 | |
and Duel.IsExistingMatchingCard(s.setfilter,tp,LOCATION_DECK,0,1,nil) end | |
end | |
function s.settg(e,tp,eg,ep,ev,re,r,rp,chk) | |
if chk==0 then return Duel.GetLocationCount(tp,LOCATION_SZONE)>0 | |
and Duel.IsExistingMatchingCard(s.setfilter,tp,LOCATION_DECK,0,1,nil) end | |
Duel.Hint(HINT_OPSELECTED,1-tp,aux.Stringid(id,0)) | |
end |
Should add a Duel.Hint
to show which effect is used.
scripts/PHNI-JP/c101203046.lua
Outdated
Comment on lines
65
to
68
function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk) | ||
if chk==0 then return Duel.IsExistingMatchingCard(s.thfilter,tp,LOCATION_DECK,0,1,nil) end | ||
Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,1,tp,LOCATION_DECK) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk) | |
if chk==0 then return Duel.IsExistingMatchingCard(s.thfilter,tp,LOCATION_DECK,0,1,nil) end | |
Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,1,tp,LOCATION_DECK) | |
end | |
function s.thtg(e,tp,eg,ep,ev,re,r,rp,chk) | |
if chk==0 then return Duel.IsExistingMatchingCard(s.thfilter,tp,LOCATION_DECK,0,1,nil) end | |
Duel.SetOperationInfo(0,CATEGORY_TOHAND,nil,1,tp,LOCATION_DECK) | |
Duel.Hint(HINT_OPSELECTED,1-tp,aux.Stringid(id,1)) | |
end |
Should add a Duel.Hint
to show which effect is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前commits太长了,重投了