Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix&update fusion material #1238

Merged
2 commits merged into from Nov 6, 2019
Merged

fix&update fusion material #1238

2 commits merged into from Nov 6, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2019

@ghost ghost merged commit 2b47e83 into Fluorohydride:master Nov 6, 2019
@ghost ghost deleted the patch-fusion branch November 6, 2019 01:39
@mercury233
Copy link
Collaborator

got this:
[Script Error]: [string "./script/utility.lua"]:1072: Parameter 1 should be "Group".
replay:
444play.zip

@ghost
Copy link
Author

ghost commented Nov 7, 2019

Sorry, I can't play this replay.
I would like to get more information.

@mercury233
Copy link
Collaborator

i didn't manage to reproduce this issue before i got this replay from another user. let me try again.

@mercury233
Copy link
Collaborator

mercury233 commented Nov 7, 2019

OK, I guess I understand it:

  1. Place Trishula, the Dragon of Icy Imprisonment and Dragonmaid Husky in extra deck
  2. Summon a Dragonmaid to field, discard a Dragonmaid to grave
  3. Activate Dragon's Mirror
  4. This error show up.

It is because when it check
https://github.com/Fluorohydride/ygopro-scripts/blob/master/c71490127.lua#L51
the mg1 is altered by
https://github.com/Fluorohydride/ygopro-core/pull/242/files#diff-8e1e3342c6da0ff99bc2f53f27026b12R2804
when Trishula is being checked

ghost pushed a commit to Fluorohydride/ygopro-core that referenced this pull request Nov 7, 2019
@ghost
Copy link
Author

ghost commented Nov 7, 2019

I could confirm these problems.
Fluorohydride/ygopro-core@e78e83a fixed. Thank you.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant