component in global namespace works

FlurinBruehwiler · Mar 8, 2024 · 0b2651f · 0b2651f
1 parent 2749261
commit 0b2651f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/Flamui.SourceGenerators/BuilderClassGenerator.cs b/Flamui.SourceGenerators/BuilderClassGenerator.cs
@@ -8,8 +8,11 @@ public static string Generate(FlamuiComponentSg component)
     {
         var sb = new SourceBuilder();
 
-        sb.AppendFormat("namespace {0};", component.Component.ContainingNamespace.ToDisplayString()).AppendLine();
-        sb.AppendLine();
+        if (!component.Component.ContainingNamespace.IsGlobalNamespace)
+        {
+            sb.AppendFormat("namespace {0};", component.Component.ContainingNamespace.ToDisplayString()).AppendLine();
+            sb.AppendLine();
+        }
 
         sb.Append("public partial struct ");
         AppendBuilderName(sb, component.Component);

diff --git a/Flamui.SourceGenerators/CreateMethodGenerator.cs b/Flamui.SourceGenerators/CreateMethodGenerator.cs
@@ -7,8 +7,11 @@ public static string Generate(FlamuiComponentSg component)
     {
         var sb = new SourceBuilder();
 
-        sb.AppendFormat("namespace {0};", component.Component.ContainingNamespace.ToDisplayString()).AppendLine();
-        sb.AppendLine();
+        if (!component.Component.ContainingNamespace.IsGlobalNamespace)
+        {
+            sb.AppendFormat("namespace {0};", component.Component.ContainingNamespace.ToDisplayString()).AppendLine();
+            sb.AppendLine();
+        }
 
         sb.AppendLine("public static partial class UiExtensions");
         sb.AppendLine("{");

diff --git a/README.md b/README.md
@@ -31,7 +31,6 @@ app.CreateWindow<RootComponent>("Hello World Window");
 
 app.Run();
 
-//ToDo, put this class into a namespace, global namspace doesn't work currently
 public class RootComponent : FlamuiComponent
 {
     public override void Build(Ui ui)