Add support for liveItem parsing within the podcast extension (Resolves #39) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add podcast_index live - Support iTunes image?? - Fix live image regex
rutvik110
approved these changes
Jan 14, 2024
| @@ -38,4 +43,6 @@ class RssPodcastIndex { | |||
|
|
|||
| /// The purpose is to tell other podcast hosting platforms whether they are allowed to import this feed. | |||
| final RssPodcastIndexLocked? locked; | |||
|
|
|||
| final List<RssPodcastIndexLiveItem?>? liveItems; | |||
There was a problem hiding this comment.
Documentation missing for this member.
| @@ -0,0 +1,23 @@ | |||
| import 'package:xml/xml.dart'; | |||
|
|
|||
| class RssPodcastIndexContentLink { | |||
| import 'package:dart_rss/util/helpers.dart'; | ||
| import 'package:xml/xml.dart'; | ||
|
|
||
| class RssPodcastIndexGuid { |
| @@ -0,0 +1,25 @@ | |||
| import 'package:xml/xml.dart'; | |||
|
|
|||
| class RssPodcastIndexLiveItemImages { | |||
|
@rutvik110 this PR is a port of another one, so I don't even know enough to fill in the docs. We need to a full project pass for Dart Docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for liveItem parsing within the podcast extension (Resolves #39)
I took an existing PR and modified it: #37
There were a couple bugs in that PR that I fixed. I also added example XML and a corresponding test update.
I discovered a couple missing parsing behaviors related to this work, but I filed #43 and #44.