Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Expose config for excluding gen files #60

Closed
vintage opened this issue Nov 26, 2020 · 2 comments
Closed

[Feature Request] Expose config for excluding gen files #60

vintage opened this issue Nov 26, 2020 · 2 comments
Assignees
@wasabeef
Labels
bug Something isn't working
Milestone
1.3.1

Comments

@vintage
Copy link

vintage commented Nov 26, 2020

I've been generating the assets and got surprised by unexpected records. Well, its kinda expected (the file exists there), but would be great to ignore these, as I don't treat .DS_Store as my project files :)

...
String get dSStore => 'animations/.DS_Store';
...

Any chance to expose exclude config (similar to the one we have in analasis_options.yaml) or at least ignore some well known files by default? <3
@lcdsmao lcdsmao added the bug Something isn't working label Nov 26, 2020
@lcdsmao lcdsmao added this to the 1.4.0 milestone Nov 26, 2020
@wasabeef wasabeef self-assigned this Nov 26, 2020
@wasabeef wasabeef modified the milestones: 1.4.0, 1.3.1 Nov 26, 2020
wasabeef added a commit that referenced this issue Nov 26, 2020
@wasabeef
fix(assets): #60 Set files like .DS_Store to the ignore list.
75e3629
@wasabeef wasabeef mentioned this issue Nov 26, 2020
Merged
wasabeef added a commit that referenced this issue Nov 26, 2020
@wasabeef
Merge pull request #61 from FlutterGen/fix-ignorefiles
5c31c1c 
fix(assets): #60 Set files like .DS_Store to the ignore list.
@wasabeef wasabeef mentioned this issue Nov 26, 2020
Merged
@wasabeef
Copy link
Member

@vintage
Thank you for your report.

We just released 1.3.1 please use it. 🎯

$ brew upgrade fluttergen/tap/fluttergen
$ dart pub global activate flutter_gen

@vintage
Copy link
Author

vintage commented Nov 26, 2020

@wasabeef Wow, thank you for the instant fix! Upgraded to 1.3.1 and the problem is gone :)

@vintage vintage closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wasabeef wasabeef

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
3 participants
@vintage @wasabeef @lcdsmao