Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #102 #103

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Fix #102 #103

merged 5 commits into from
Apr 8, 2021

Conversation

lcdsmao
Copy link
Member

@lcdsmao lcdsmao commented Apr 8, 2021

What does this change?

fix #102
related #98 #50

Add option packageParameterEnabled to control whether to generate package parameter for assets or not.

What is the value of this and can you measure success?

Sample work

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #103 (80a9d11) into main (cd9f870) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   52.54%   52.25%   -0.29%     
==========================================
  Files          43       43              
  Lines        3719     3728       +9     
==========================================
- Hits         1954     1948       -6     
- Misses       1765     1780      +15     
Impacted Files Coverage Δ
packages/core/lib/settings/config.dart 100.00% <ø> (ø)
packages/core/lib/generators/assets_generator.dart 100.00% <100.00%> (ø)
...e/lib/generators/integrations/svg_integration.dart 100.00% <100.00%> (ø)
packages/core/lib/settings/pubspec.dart 84.84% <100.00%> (ø)
packages/core/lib/settings/pubspec.g.dart 100.00% <100.00%> (ø)
...ib/utils/dart_style/src/argument_list_visitor.dart 54.43% <0.00%> (-6.33%) ⬇️
...s/core/lib/utils/dart_style/src/rule/argument.dart 45.20% <0.00%> (-5.48%) ⬇️
.../core/lib/utils/dart_style/src/source_visitor.dart 35.82% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9f870...80a9d11. Read the comment docs.

@lcdsmao lcdsmao requested a review from wasabeef April 8, 2021 02:33
@wasabeef wasabeef added this to the 3.1.1 milestone Apr 8, 2021
@lcdsmao lcdsmao merged commit 070c172 into main Apr 8, 2021
@lcdsmao lcdsmao deleted the fix/102 branch April 8, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.0 Package implementation breaks app usage.
2 participants