Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace null safety dart style package #110

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

lcdsmao
Copy link
Member

@lcdsmao lcdsmao commented May 30, 2021

What does this change?

dart_style has published null-safety version.
Use pub version instead of copying source code.

What is the value of this and can you measure success?

CI Pass

@lcdsmao lcdsmao requested a review from wasabeef May 30, 2021 01:22
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #110 (c680c5f) into main (63409c3) will increase coverage by 45.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #110       +/-   ##
===========================================
+ Coverage   52.19%   97.86%   +45.66%     
===========================================
  Files          43       18       -25     
  Lines        3728      563     -3165     
===========================================
- Hits         1946      551     -1395     
+ Misses       1782       12     -1770     
Impacted Files Coverage Δ
packages/core/lib/flutter_generator.dart 93.54% <ø> (ø)
packages/core/lib/generators/assets_generator.dart 100.00% <ø> (ø)
packages/core/lib/generators/colors_generator.dart 98.21% <ø> (ø)
packages/core/lib/generators/fonts_generator.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63409c3...c680c5f. Read the comment docs.

Copy link
Member

@wasabeef wasabeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit: :shipit:

@lcdsmao lcdsmao merged commit dde0c14 into main May 30, 2021
@lcdsmao lcdsmao deleted the build-dart-style branch May 30, 2021 04:38
@wasabeef wasabeef mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants