Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify generated assets style #33

Merged
merged 15 commits into from
Sep 10, 2020
Merged

Conversation

lcdsmao
Copy link
Member

@lcdsmao lcdsmao commented Sep 9, 2020

What does this change?

Add support to generate flat hierarchy assets with field name style:

  • camel-case
  • snake-case

What is the value of this and can you measure success?

CI pass

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #33 into main will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   95.61%   96.06%   +0.45%     
==========================================
  Files          15       15              
  Lines         365      407      +42     
==========================================
+ Hits          349      391      +42     
  Misses         16       16              
Impacted Files Coverage Δ
lib/src/generators/colors_generator.dart 95.45% <ø> (ø)
lib/src/generators/fonts_generator.dart 100.00% <ø> (ø)
lib/src/generators/assets_generator.dart 100.00% <100.00%> (ø)
lib/src/settings/flutter_gen.dart 96.77% <100.00%> (+1.31%) ⬆️
lib/src/utils/string.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324cc4d...528130c. Read the comment docs.

@lcdsmao lcdsmao changed the title WIP Specify generated assets style Specify generated assets style Sep 10, 2020
lib/src/generators/assets_generator.dart Outdated Show resolved Hide resolved
lib/src/generators/assets_generator.dart Outdated Show resolved Hide resolved
lib/src/generators/assets_generator.dart Outdated Show resolved Hide resolved
lib/src/generators/assets_generator.dart Outdated Show resolved Hide resolved
lib/src/generators/assets_generator.dart Show resolved Hide resolved
Copy link
Member

@wasabeef wasabeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Good Good.

Work well !!

@wasabeef wasabeef merged commit d561ba8 into FlutterGen:main Sep 10, 2020
@wasabeef wasabeef added this to the 1.1.0 milestone Sep 11, 2020
@wasabeef wasabeef mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants