Add profile share. #252
Closed
Add profile share. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FlutterKaigi/conference-app-2023 |
8 tasks
koji-1009
reviewed
Nov 6, 2023
| @@ -1,3 +1,4 @@ | |||
| org.gradle.jvmargs=-Xmx1536M | |||
| android.useAndroidX=true | |||
| android.enableJetifier=true | |||
| dev.steenbakker.mobile_scanner.useUnbundled=true | |||
There was a problem hiding this comment.
pubspec.yaml
Outdated
| @@ -36,6 +36,7 @@ dependencies: | |||
|
|
|||
| adaptive_dialog: ^1.9.0-0 | |||
| auto_size_text: ^3.0.0 | |||
| mobile_scanner: ^3.0.0 | |||
There was a problem hiding this comment.
image_pickerの次の行に追加でどうでしょう。
Comment on lines
+25
to
+28
| @override | ||
| Widget build(BuildContext context, GoRouterState state) { | ||
| return const ScanCodePage(); | ||
| } |
There was a problem hiding this comment.
@override
Page<void> buildPage(BuildContext context, GoRouterState state) {
return MaterialPage(
key: state.pageKey,
child: const ScanCodePage(),
fullscreenDialog: true,
);
}こちらのコードに書き換えて、iOSだとmodalとして下から開くようになります。
また、自動的にBackButtonがCloseButtonに置き換わります。こちらの方が意図通りかなと。
| TargetPlatform.android || TargetPlatform.iOS => true, | ||
| _ => false, | ||
| }; | ||
| final canReadQrCode = id != null && name.isNotEmpty; |
There was a problem hiding this comment.
nameの入力後、キーボード上で done をしないと、値が切り替わらない状態になっていました。
onChange をある程度監視するか、submit的なボタンを用意した方が良さそうです。
There was a problem hiding this comment.
これはある程度意図的でした。onChange だと文字を入力するたびにQRコードが変化したりセクション自体が消えたりするのでUIに変化がありすぎるかなと思ってます。
| } else { | ||
| final imageUrl = ref.watch(imageDownloadUrlProvider(url)); | ||
| image = switch (imageUrl) { | ||
| AsyncData(value: final value) => value.isEmpty |
|
Profile画面でQRを出した際、スクロール時に若干フレームが落ちてますね。Androidだと注意深く見ると気になる程度、iOSだとスクロールのfpsが足りてないのがぱっと見でわかる程度です。なんでだろう。 |
|
Commented by GitHub Bot PR: #252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist
flutter format lib.dart fix --apply lib.