Skip to content

Commit

Permalink
refactor: add hide Router to Widgets and Material imports
Browse files Browse the repository at this point in the history
  • Loading branch information
gladson committed Aug 14, 2020
1 parent 542adc4 commit 5f7dd03
Show file tree
Hide file tree
Showing 14 changed files with 38 additions and 24 deletions.
2 changes: 1 addition & 1 deletion flutter_modular/example/lib/app/app_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;
import 'package:flutter_modular/flutter_modular.dart';

import 'app_widget.dart';
Expand Down
7 changes: 5 additions & 2 deletions flutter_modular/example/lib/app/modules/home/home_module.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import 'package:example/app/modules/home/pages/list/list_widget.dart';
import 'package:flutter/material.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';
import 'package:flutter/material.dart';

import 'pages/list/list_widget.dart';

import 'guard/guard.dart';
import 'home_bloc.dart';
import 'home_widget.dart';
Expand Down
2 changes: 1 addition & 1 deletion flutter_modular/example/lib/main_guardtest.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:flutter/material.dart';
import 'package:flutter/material.dart' hide Router;
import 'package:flutter_modular/flutter_modular.dart';

void main() => runApp(ModularApp(module: AppModule()));
Expand Down
3 changes: 2 additions & 1 deletion flutter_modular/lib/src/interfaces/child_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/material.dart' hide Router;
import 'package:flutter/widgets.dart' hide Router;

import '../../flutter_modular.dart';
import '../routers/router.dart';
Expand Down
4 changes: 3 additions & 1 deletion flutter_modular/lib/src/modular_base.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'package:flutter/material.dart' hide Router;

import 'package:flutter/foundation.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;

import '../flutter_modular.dart';
import 'interfaces/child_module.dart';
Expand Down
3 changes: 2 additions & 1 deletion flutter_modular/lib/src/routers/router.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/material.dart' hide Router;

import '../../flutter_modular.dart';
import '../interfaces/child_module.dart';
import '../interfaces/route_guard.dart';
Expand Down
2 changes: 1 addition & 1 deletion flutter_modular/lib/src/widgets/module_widget.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;
import '../../flutter_modular.dart';

_debugPrintModular(String text) {
Expand Down
2 changes: 1 addition & 1 deletion flutter_modular/lib/src/widgets/widget_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;
import '../../flutter_modular.dart';

_debugPrintModular(String text) {
Expand Down
4 changes: 3 additions & 1 deletion flutter_modular/test/abstract_router_test.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'package:flutter/material.dart';
import 'package:flutter/material.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import 'package:flutter_test/flutter_test.dart';

class DynamicModule extends ChildModule {
Expand Down
3 changes: 2 additions & 1 deletion flutter_modular/test/app/app_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import 'app_bloc.dart';
Expand Down
3 changes: 2 additions & 1 deletion flutter_modular/test/app/modules/home/home_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import '../../app_bloc.dart';
Expand Down
3 changes: 2 additions & 1 deletion flutter_modular/test/app/modules/product/product_module.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import 'product_bloc.dart';
Expand Down
7 changes: 5 additions & 2 deletions flutter_modular/test/modular_test.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/widgets.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import 'package:flutter_test/flutter_test.dart';

import 'app/app_module.dart';

void main() {
Expand Down
17 changes: 8 additions & 9 deletions flutter_modular/test/routers/router_test.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'package:flutter/widgets.dart';
import 'package:flutter/widgets.dart' hide Router;

import 'package:flutter_modular/flutter_modular.dart';

import 'package:flutter_test/flutter_test.dart';

class TestModule extends ChildModule {
Expand All @@ -8,7 +10,6 @@ class TestModule extends ChildModule {

@override
List<Router> get routers => [];

}

void main() {
Expand All @@ -22,18 +23,16 @@ void main() {

test('throws ArgumentError if both the module and child was provided', () {
expect(() {
Router('/',
module: TestModule(),
child: (_, __) => SizedBox.shrink()
);
Router('/', module: TestModule(), child: (_, __) => SizedBox.shrink());
}, throwsArgumentError);
});

test('throws ArgumentError if transaction is null', () {
expect(() {
Router('/',
child: (_, __) => SizedBox.shrink(),
transition: null,
Router(
'/',
child: (_, __) => SizedBox.shrink(),
transition: null,
);
}, throwsArgumentError);
});
Expand Down

0 comments on commit 5f7dd03

Please sign in to comment.