Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Router class's arguments validation #12

Conversation

pedromassango
Copy link
Contributor

I've just improved the Router class by:

  • Assert that routeName is not null
  • Asserting that transaction argument must not be null
  • Asserting that only module or child must be provided and never both
  • Fix routeName null if the function copyWith is called without providing the routeName property

@jacobaraujo7
Copy link
Contributor

Hello.
Thanks for your pull!
Have errors in unity test, please, check logs

@pedromassango
Copy link
Contributor Author

Hello.
Thanks for your pull!
Have errors in unity test, please, check logs

Ok, it was failing because some tests was not meeting the requirement

@jacobaraujo7 jacobaraujo7 merged commit 830bca6 into Flutterando:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants