Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable get instance by tag #880

Closed
wants to merge 4 commits into from

Conversation

toshiossada
Copy link
Contributor

@toshiossada toshiossada commented Aug 16, 2023

Description

Once it's possible add Bind with tag should be abble to get intance by tag name too
this PR depends on Auto Injector PR Flutterando/auto_injector#8

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Currently you coundnt get Moduler.get() by tag

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #880 (44c9118) into master (79e97b2) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            master      #880    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           40        14    -26     
  Lines          929       311   -618     
==========================================
- Hits           929       311   -618     

see 26 files with indirect coverage changes

@jacobaraujo7
Copy link
Contributor

As tags servem pra outra coisa.
É mais uma organização de módulo do que a chave que armazena a instancia. Por tanto não vai funcionar.
A modificação tem que ser primeiro no AutoInjector, depois aqui no modular.
O Deivao está fazendo uma mudança no sistema de módulos, pode ser que encaixe lá/

@toshiossada
Copy link
Contributor Author

As tags servem pra outra coisa. É mais uma organização de módulo do que a chave que armazena a instancia. Por tanto não vai funcionar. A modificação tem que ser primeiro no AutoInjector, depois aqui no modular. O Deivao está fazendo uma mudança no sistema de módulos, pode ser que encaixe lá/

eu fiz a alteraçao no Autoinjector tb, so tive que mudar no modular para ele passar a tag para o auto injector, mas a alteraçao principal esta la

@jacobaraujo7
Copy link
Contributor

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants