Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #883 #872 Bugs Import Export Modules Dependencies #884

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Bwolfs2
Copy link
Member

@Bwolfs2 Bwolfs2 commented Aug 24, 2023

Description

Fix: #883 #872
Bugs Import Export Modules Dependencies

Checklist

  • [ x] The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • [ x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • [ x] I have updated/added tests for ALL new/updated/fixed functionality.
  • [ x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • [x ] No, this is not a breaking change.

Related Issues

(#883)
#872

@Bwolfs2 Bwolfs2 self-assigned this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #884 (c53a9b1) into master (8f669c3) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #884   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          817       817           
=========================================
  Hits           817       817           
Files Changed Coverage Δ
modular_core/lib/src/tracker.dart 100.00% <100.00%> (ø)

@jacobaraujo7 jacobaraujo7 merged commit 9fdfbcb into master Aug 28, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: replaceInstance not working correctly on multiple exported modules
2 participants