Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Path resolution strategy for Flutter Web hosted outside of base path (issue #941) #942

Merged
merged 3 commits into from
May 23, 2024

Conversation

camrongiuliani
Copy link
Contributor

Description

Fix: Path resolution strategy for Flutter Web hosted outside of base path (issue #941)

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes: #941

@jacobaraujo7
Copy link
Contributor

Hello!
Apologies for the delay. I was having some personal problems.
I need you to correct Ci's mistakes so we can continue. Thanks

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (b838b40) to head (98c9188).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   99.87%   99.51%   -0.37%     
==========================================
  Files          34        8      -26     
  Lines         824      206     -618     
==========================================
- Hits          823      205     -618     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobaraujo7 jacobaraujo7 merged commit 07d7e8b into Flutterando:master May 23, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebUrlService not compatible with Flutter Web apps deployed outside of root path
2 participants