Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript init and Bills, Banks and Beneficiaries working #85

Closed
wants to merge 7 commits into from

Conversation

iamsethsamuel
Copy link

I have set up typescript and added type to Banks, Bill and Beneficiaries. They are all working with their appropriate types. Please let me know what you think so I should know how to process ASAP. Thanks

@iamsethsamuel
Copy link
Author

Is anyone seeing this or should I just abandon the project

@orimdominic
Copy link

orimdominic commented Sep 28, 2022

@iamsethsamuel Nice work!

The changes in this PR are much. Very much.
You are requesting to merge your work to a live product. It needs to be tested and reviewed to make sure that it does not break anything (I'm not implying that it does).
Another thing is that a project such as converting a codebase from JS to TS needs to have a plan and follow a step-wise process.
Did you read the contributions guide?
👍

@iamsethsamuel
Copy link
Author

@iamsethsamuel Nice work!

The changes in this PR are much. Very much. You are requesting to merge your work to a live product. It needs to be tested and reviewed to make sure that it does not break anything (I'm not implying that it does). Another thing is that a project such as converting a codebase from JS to TS needs to have a plan and follow a step-wise process. Did you read the contributions guide? +1

Yeah, it's really big. I was thinking that you guys can create a branch for the transition. #69 (comment) plan is perfect. So if you can create the branch, I will close this PR and recreate it on that branch and we continue from there. And when all is tested, that branch can be merged with the main branch

@corneliusyaovi
Copy link
Collaborator

Hi @iamsethsamuel,

Please raise these changes against the dev branch. Based on the volume of changes made, it would take us some time to review and test for unintended changes, but rest assured, we would work on it.

We appreciate you for making contributions to the library. I'd be in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants