Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #110

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Dev #110

merged 2 commits into from
Jul 21, 2023

Conversation

corneliusyaovi
Copy link
Contributor

Requirements for contributing to the library

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Include the issue link for bug fixes.
  • The pull request must include a test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must pass before a maintainer reviews your contribution.

Type of change

[] Bug fix
[] Performance improvement
[] Documentation update

Description of the change

Related issue

Checklist

[] I have read the contribution document.
[] I have added tests to cover my changes.
[] All new and existing tests passed.

Release Notes

@gitguardian
Copy link

gitguardian bot commented Jul 21, 2023

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
381514 Generic High Entropy Secret 6a05c0b test.py View secret
381514 Generic High Entropy Secret 6a05c0b test.py View secret
381514 Generic High Entropy Secret 6a05c0b test.py View secret
381515 Generic High Entropy Secret 6a05c0b test.py View secret
7411019 Generic High Entropy Secret 6a05c0b example.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@corneliusyaovi corneliusyaovi merged commit 4e6247d into master Jul 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant