Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing DLPipelines.jl; Learning method -> Learning task #198

Merged
merged 7 commits into from
Mar 18, 2022

Conversation

lorenzoh
Copy link
Member

@lorenzoh lorenzoh commented Mar 3, 2022

This will incorporate DLPipelines.jl directly into FastAI.jl and drop the dependency. This is a BREAKING change.

In the process, the following changes will be made to the LearningMethod interfaces:

  • Rename LearningMethod to LearningTask, method to task
    • In an earlier version of DLPipelines.jl, LearningTask was an abstract parametric type for LearningMethods to signify that there can be multiple ways of solving a task, but this was dropped at some point.
    • LearningTask is imo a more intention-revealing name, as method is a very ambiguous term (especially in Julia-land). This is especially true for the short variable name task vs method.
    • As a result of this, subtypes of LearningMethod will also be renamed. Specifically, [Abstract]BlockMethod -> [Abstract]BlockTask and SupervisedMethod -> SupervisedTask.
    • methoddataset -> taskdataset and methoddataloaders -> taskdataloaders
    • findlearningmethods -> findlearningtasks
  • Clean up the basic LearningMethod interface:
    • rename encode(method, ctx, sample) to encodesample. This way, encode is reserved for Encodings.
    • rename decodeŷ to decodeypred . Easier to write and to differentiate from decodey . Old name will be aliased.
  • update CHANGELOG

@lorenzoh lorenzoh merged commit 294f367 into master Mar 18, 2022
@lorenzoh lorenzoh mentioned this pull request Mar 19, 2022
@lorenzoh lorenzoh deleted the lorenzoh/drop-dlpipelines branch October 21, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant