Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OneHotArrays.jl v0.2 #2109

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Allow OneHotArrays.jl v0.2 #2109

merged 2 commits into from
Nov 14, 2022

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Nov 10, 2022

This currently blocks MLUtils v0.3. Not sure if there are reasons to delay.

(jl_uNbWM9) pkg> add MLUtils@0.3
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package OneHotArrays [0b1bfda6]:
 OneHotArrays [0b1bfda6] log:
 ├─possible versions are: 0.1.0 or uninstalled
 ├─restricted to versions 0.1 by Flux [587475ba], leaving only versions: 0.1.0
 │ └─Flux [587475ba] log:
 │   ├─possible versions are: 0.13.8 or uninstalled
 │   └─Flux [587475ba] is fixed to version 0.13.8
 └─restricted by compatibility requirements with MLUtils [f1d291b0] to versions: uninstalled — no versions left
   └─MLUtils [f1d291b0] log:
     ├─possible versions are: 0.1.0-0.3.0 or uninstalled
     ├─restricted to versions 0.2-0.3 by Flux [587475ba], leaving only versions: 0.2.0-0.3.0
     │ └─Flux [587475ba] log: see above
     └─restricted to versions 0.3 by an explicit requirement, leaving only versions: 0.3.0

Closes #2111

@CarloLucibello
Copy link
Member

OneHotArrays.jl still needs the v0.2 tag. If we are not waiting for something else to get into the release we can tag now

@mcabbott
Copy link
Member Author

Oh I see now.

Tagging a OneHotArrays 0.1.1 which allows MLUtils 0.3 might be another option.

@CarloLucibello
Copy link
Member

I think we can just tag v0.2, I don't think anyone is planning additional breaking changes. The breaking was in FluxML/OneHotArrays.jl#20, and seems a minor one, the change in the type parameterization.

@mcabbott
Copy link
Member Author

Now fails with:

WARNING: both MLUtils and Base export "rpad"; uses of it in module Flux must be qualified
nested model printing: Error During Test at /home/runner/work/Flux.jl/Flux.jl/test/layers/show.jl:9
  Got exception outside of a @test
  UndefVarError: rpad not defined

Looks like the change is

JuliaML/MLUtils.jl@5a39b1f#diff-5b453f8f7fb34afbebfc6f688a8209aa0532c8b1c3e95393f97afcbc37a473e7L13-R12

which replaces piracy with exporting a new function of the same name, clashing with Base's.

@codecov-commenter
Copy link

Codecov Report

Base: 86.90% // Head: 86.90% // No change to project coverage 👍

Coverage data is based on head (34c57d3) compared to base (4662c4c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2109   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          18       18           
  Lines        1420     1420           
=======================================
  Hits         1234     1234           
  Misses        186      186           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcabbott mcabbott merged commit ad988da into master Nov 14, 2022
@mcabbott mcabbott deleted the mcabbott-patch-2 branch November 14, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants