-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow OneHotArrays.jl v0.2 #2109
Conversation
OneHotArrays.jl still needs the v0.2 tag. If we are not waiting for something else to get into the release we can tag now |
Oh I see now. Tagging a OneHotArrays 0.1.1 which allows MLUtils 0.3 might be another option. |
I think we can just tag v0.2, I don't think anyone is planning additional breaking changes. The breaking was in FluxML/OneHotArrays.jl#20, and seems a minor one, the change in the type parameterization. |
Now fails with:
Looks like the change is which replaces piracy with exporting a new function of the same name, clashing with Base's. |
Codecov ReportBase: 86.90% // Head: 86.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 18 18
Lines 1420 1420
=======================================
Hits 1234 1234
Misses 186 186 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This currently blocks MLUtils v0.3. Not sure if there are reasons to delay.
Closes #2111