-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cl functions for CLArrays #72
Conversation
needs JuliaGPU/CLArrays.jl#3 |
This is great to have! However, it's not ideal for Flux to know about all backends like this, so I just added a mechanism that enables the same thing in a generic way. Would CLArrays be able to hook into that, so that we get all this functionality for free? |
I think it's a bit odd to rely on NNlib for that... Why not have this in GPUArrays and have Flux rely on that? |
See JuliaGPU/CUDAnative.jl#121. I can move that function into a separate package if others are on board with the approach. |
Isn't that the perfect use case for moving it into GPUArrays? |
Not really. It's completely orthogonal from GPU support (that just happens to be our use case) and CUDAnative isn't going to want to depend on an array abstraction any more than an ML lib. |
Okay didn't realize this isn't just functionality for GPU Arrays anymore... |
Also, if you want CLArrays to work with Flux then you'll need to implement the NNlib API for softmax, convolution etc, so it dovetails quite nicely with that. |
Well, as long as I don't have clDNN wrapped, that would live in GPUArrays ;) |
Closing in favour of JuliaGPU/GPUArrays.jl#89 |
No description provided.