Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cl functions for CLArrays #72

Closed
wants to merge 1 commit into from

Conversation

SimonDanisch
Copy link
Contributor

No description provided.

@SimonDanisch
Copy link
Contributor Author

needs JuliaGPU/CLArrays.jl#3

@MikeInnes
Copy link
Member

This is great to have! However, it's not ideal for Flux to know about all backends like this, so I just added a mechanism that enables the same thing in a generic way. Would CLArrays be able to hook into that, so that we get all this functionality for free?

@SimonDanisch
Copy link
Contributor Author

I think it's a bit odd to rely on NNlib for that... Why not have this in GPUArrays and have Flux rely on that?
It's quite natural to have Flux rely on GPUArrays!

@MikeInnes
Copy link
Member

See JuliaGPU/CUDAnative.jl#121. I can move that function into a separate package if others are on board with the approach.

@SimonDanisch
Copy link
Contributor Author

Isn't that the perfect use case for moving it into GPUArrays?

@MikeInnes
Copy link
Member

Not really. It's completely orthogonal from GPU support (that just happens to be our use case) and CUDAnative isn't going to want to depend on an array abstraction any more than an ML lib.

@SimonDanisch
Copy link
Contributor Author

Okay didn't realize this isn't just functionality for GPU Arrays anymore...

@MikeInnes
Copy link
Member

Also, if you want CLArrays to work with Flux then you'll need to implement the NNlib API for softmax, convolution etc, so it dovetails quite nicely with that.

@MikeInnes MikeInnes mentioned this pull request Oct 10, 2017
@SimonDanisch
Copy link
Contributor Author

Well, as long as I don't have clDNN wrapped, that would live in GPUArrays ;)
And if I do, I'd expect the interface to live in GPUArrays (maybe just reexporting NNlib), and then overload it in CLArrays with clDNN...

@MikeInnes
Copy link
Member

Closing in favour of JuliaGPU/GPUArrays.jl#89

@MikeInnes MikeInnes closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants