make call to get IR object more direct #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the world age problem with `code_lowered`
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 74.98% 74.98%
=======================================
Files 15 15
Lines 1419 1419
=======================================
Hits 1064 1064
Misses 355 355
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
IanButterworth
added a commit
to IanButterworth/IRTools.jl
that referenced
this pull request
Apr 26, 2023
Co-Authored-By: Jameson Nash <vtjnash+github@gmail.com>
Merged
|
Fixes #111 |
CarloLucibello
pushed a commit
that referenced
this pull request
May 10, 2023
* fix replace_code_newstyle! on 1.10 * fix from #112 Co-Authored-By: Jameson Nash <vtjnash+github@gmail.com> * add world to get_staged * try some types * fix older get_staged * only set slotypes on 1.10 * initialize slottypes as a Vector{Any} if nothing * Adapt to change in generated functions. Co-Authored-By: Tim Besard <383068+maleadt@users.noreply.github.com> * unmark test as broken on julia v1.10 * No need to use the generated world when constructing from IR. * Spoof the current world to make dynamos work without a breaking API change. * Fix typo. * Don't copy slottypes if they aren't set. * Re-mark test broken. * Generate stub for every non-CI. --------- Co-authored-by: Jameson Nash <vtjnash+github@gmail.com> Co-authored-by: Tim Besard <383068+maleadt@users.noreply.github.com> Co-authored-by: Tim Besard <tim.besard@gmail.com>
|
This is included in #109. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the world age problem with
code_lowered