fix IRTools on Julia 1.6 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Nov 21, 2020
| terminator = true | ||
| elseif isexpr(ex, GotoNode, :return) | ||
| elseif ex isa GotoNode || isreturn(ex) |
There was a problem hiding this comment.
No, I am pretty sure this is correct: https://github.com/FluxML/MacroTools.jl/blob/a03742057f388899833c9000ebf56dbd9616a6d5/src/utils.jl#L39. ex can only be either a GotoNode or a ReturnNode, not both.
|
Nightly tests pass! 🎉 Could anyone merge this? |
|
Thanks, this is great! I will run this with Zygote and Flux on 1.6, and get on it |
|
FYI, this isn't enough for Zygote yet. I have started working on that in this branch and a corresponding one for ZygoteRules, but I don't currently have time to further look into what it would take to get all Zygote tests to pass on 1.6 |
|
Ah, alright, for now let's merge this, thanks again! |
|
Would it be possible to also tag a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs JuliaLang/julia#38519. This passes all tests for me locally, but coverage is not great, so there might still be cases I missed.