New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation with module in func() #85

Merged

CarloLucibello merged 1 commit into FluxML:master from dfdx:dfdx/fix-func

Feb 12, 2023

Contributor

dfdx commented Mar 28, 2021

While trying to construct a function from IR in my package, I got an error:

Evaluation into the closed module Inner breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating Inner with eval during precompilation - don't do this.

After some investigation, I found out that IRTools.func(m, ir) takes module argument, but doesn't actually use it. This PR fixes it.

I wasn't able to reproduce this issue in tests In reasonable time to prevent future regressions, but I hope the change still makes sense.


          Fix evaluation with module in func()

1bdbbd8

CarloLucibello merged commit 28081d8 into FluxML:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment