-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add constructor for binary classifiers #248
base: dev
Are you sure you want to change the base?
Conversation
I think the test failures are unrelated to this PR? |
@tiemvanderdeure Thanks for this PR, which looks like a valuable contribution. I'll try to investigate the fail soon and get back you. |
@tiemvanderdeure The source of your fail is sorted. Do you mind rebasing onto dev? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tiemvanderdeure for this contribution and taking the time to wrap your head around the code base.
I can see attention to detail in the PR, which is much appreciated. I couldn't spot any flaws in your implementation. Are you happy to add some tests?
Thanks for reviewing. I'll add some tests and documentation later this week! |
@tiemvanderdeure I'm tweaking the tests a bit at #251. I suggest you wait till I finish that before writing your tests. Sorry for any inconvenience. |
Regarding tests: I don't think it is nessary to run |
Re documentation. In view of #252 just merged, you just need to update the table at https://github.com/FluxML/MLJFlux.jl/blob/dev/docs/src/interface/Summary.md and write a model doc-string, modelled on the existing classifier. |
This PR adds a separate constructor
NeuralNetworkBinaryClassifier
for binary classification.Unlike for the existing
NeuralNetworkClassifier
constructor, in the final layer always has size 1. By default, a sigmoid function is used to transform this layer. This is a pretty common thing to use neural networks for, and as far as I can tell it's not possible with the existing constructors.I'll add tests and documentation if this PR gets some support.
PR Checklist